Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove waitForElement #969

Merged
merged 3 commits into from
Jun 8, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 3, 2021

BREAKING CHANGE: Remove deprecated waitForElement

What:

Remove deprecated waitForElement

Why:

The method was deprecated for some time now.

How:

Checklist:

  • [ ] Documentation added to the
    docs site
    Will do when we release the next major.
  • Tests
  • Typescript definitions updated
  • Ready to be merged

@eps1lon eps1lon force-pushed the feat/remove-wait-for-element branch from b326979 to 8628be9 Compare June 8, 2021 09:42
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8628be9:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 8, 2021

Codecov Report

Merging #969 (8628be9) into alpha (c9748e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #969   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        24    -1     
  Lines          914       902   -12     
  Branches       282       279    -3     
=========================================
- Hits           914       902   -12     
Flag Coverage Δ
node-10.14.2 100.00% <ø> (ø)
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-15 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9748e9...8628be9. Read the comment docs.

@eps1lon eps1lon added the BREAKING CHANGE This change will require a major version bump label Jun 8, 2021
@eps1lon eps1lon merged commit 532106b into testing-library:alpha Jun 8, 2021
@eps1lon eps1lon deleted the feat/remove-wait-for-element branch June 8, 2021 09:46
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This PR is included in version 8.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released on @alpha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant