Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update kcd-scripts to 11.x #962

Merged
merged 8 commits into from
Jun 8, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 28, 2021

Gradually pushing one major bump at a time.

What:

Bump kcd-scripts to 11.x

Why:

Verify jest 27 compat

How:

Bump kcd-scripts gradually to 11.x

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d5ea52:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented May 28, 2021

Codecov Report

Merging #962 (7d5ea52) into alpha (86fb094) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #962   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        25    -1     
  Lines          966       914   -52     
  Branches       298       282   -16     
=========================================
- Hits           966       914   -52     
Flag Coverage Δ
node-10.14.2 100.00% <100.00%> (ø)
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-15 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/role-helpers.js 100.00% <ø> (ø)
src/suggestions.js 100.00% <ø> (ø)
src/get-user-code-frame.js 100.00% <100.00%> (ø)
src/helpers.js 100.00% <100.00%> (ø)
src/queries/role.js 100.00% <100.00%> (ø)
src/queries/text.ts 100.00% <100.00%> (ø)
src/queries/title.ts 100.00% <100.00%> (ø)
src/query-helpers.js 100.00% <100.00%> (ø)
src/wait-for.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f8d912...7d5ea52. Read the comment docs.

@eps1lon
Copy link
Member Author

eps1lon commented May 28, 2021

It's passing locally (git clean -fdx; npm install; npm run validate;) on ubuntu with node 12.22.1 (same as GH actions) but failing in GitHub actions. This is going to be fun.

@eps1lon eps1lon force-pushed the chore/bump-kcd-scripts branch 5 times, most recently from f14b365 to f1a8a14 Compare June 1, 2021 08:52
@eps1lon eps1lon mentioned this pull request Jun 1, 2021
4 tasks
@eps1lon eps1lon marked this pull request as ready for review June 1, 2021 09:36
@eps1lon eps1lon marked this pull request as draft June 1, 2021 09:37
@eps1lon eps1lon mentioned this pull request Jun 3, 2021
4 tasks
@eps1lon eps1lon force-pushed the chore/bump-kcd-scripts branch from f1a8a14 to fd06070 Compare June 3, 2021 13:57
@eps1lon eps1lon changed the base branch from main to alpha June 3, 2021 13:57
@eps1lon eps1lon marked this pull request as ready for review June 3, 2021 14:10
@eps1lon eps1lon force-pushed the chore/bump-kcd-scripts branch 2 times, most recently from 6dda2da to 7d5ea52 Compare June 7, 2021 11:55
@eps1lon eps1lon merged commit c9748e9 into testing-library:alpha Jun 8, 2021
@eps1lon eps1lon deleted the chore/bump-kcd-scripts branch June 8, 2021 07:38
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

🎉 This PR is included in version 8.0.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants