Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Format codebase with prettier #955

Merged
merged 3 commits into from
May 10, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 6, 2021

What:

Why:

Codeformat is beginning to drift. It adds noise to PRs if unrelated code looks like it changed at first glance.

How:

  • npm run kcd-scripts format locally
  • npm run kcd-scripts format -- --check in CI

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d9d9e7e:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #955 (d9d9e7e) into main (13efbb3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #955   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           26        26           
  Lines          962       962           
  Branches       290       290           
=========================================
  Hits           962       962           
Flag Coverage Δ
node-10.14.2 100.00% <100.00%> (ø)
node-12 100.00% <100.00%> (ø)
node-14 100.00% <100.00%> (ø)
node-15 100.00% <100.00%> (ø)
node-16 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/event-map.js 100.00% <100.00%> (ø)
src/wait-for-element-to-be-removed.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13efbb3...d9d9e7e. Read the comment docs.

eps1lon added 2 commits May 6, 2021 17:19
kcd-scripts format runs with --write by default.
So we end up with --check --write which always exits with 0 if the formatting was succesful
@eps1lon eps1lon marked this pull request as ready for review May 6, 2021 15:28
@eps1lon eps1lon merged commit 4b2976d into testing-library:main May 10, 2021
@eps1lon eps1lon deleted the chore/format branch May 10, 2021 07:31
@github-actions
Copy link

🎉 This PR is included in version 7.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants