Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Consider title for name of svg element #695

Merged
merged 1 commit into from
Jul 13, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jul 13, 2020

What:

Closes #685

Why:

https://developer.mozilla.org/en-US/docs/Web/SVG/Element/title#:~:text=The%20element%20provides%20an,display%20it%20as%20a%20tooltip.

How:

Propagate eps1lon/dom-accessibility-api#324 to library dependents.

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] Tests (tested in dom-accessibility-api)
  • [ ] Typescript definitions updated
  • Ready to be merged

@eps1lon eps1lon added the bug Something isn't working label Jul 13, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e12df59:

Sandbox Source
kentcdodds/react-testing-library-examples Configuration

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet 💯

@kentcdodds kentcdodds merged commit 2215770 into testing-library:master Jul 13, 2020
@eps1lon eps1lon deleted the fix/svg-title branch July 13, 2020 21:53
@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.20.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG nested <title> should be an accessible name
2 participants