Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove mutationobserver shim #457

Merged
merged 2 commits into from
Mar 4, 2020
Merged

feat: remove mutationobserver shim #457

merged 2 commits into from
Mar 4, 2020

Conversation

kentcdodds
Copy link
Member

What: Remove @sheerun/mutationobserver-shim from the project

Why: MutationObserve is supported by all major platforms we're targeting, and people can still add the shim themselves if they need to.

How: Now, we simply retrieve the window from the node they give us, and then reference the MutationObserver off of that.

Checklist:

  • Documentation added to the
    docs site N/A
  • I've prepared a PR for types targeting
    DefinitelyTyped N/A
  • Tests
  • Ready to be merged

Closes #413

Closes #413

BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c96e7f:

Sandbox Source
fervent-panini-f4blf Configuration

@kentcdodds kentcdodds changed the title Remove MutationObserver Shim feat: remove mutationobserver shim Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #457 into beta will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           beta   #457   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        22     22           
  Lines       412    412           
  Branches     99     98    -1     
===================================
  Hits        412    412
Impacted Files Coverage Δ
src/events.js 100% <ø> (ø) ⬆️
src/helpers.js 100% <ø> (ø) ⬆️
src/wait.js 100% <100%> (ø) ⬆️
src/wait-for-dom-change.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5aa6386...3c96e7f. Read the comment docs.

@kentcdodds kentcdodds merged commit 5fae126 into beta Mar 4, 2020
@kentcdodds kentcdodds deleted the pr/remove-shim branch March 4, 2020 18:27
@kentcdodds
Copy link
Member Author

🎉 This PR is included in version 7.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

kentcdodds pushed a commit that referenced this pull request Mar 4, 2020
Closes #413
Closes #357

BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
kentcdodds pushed a commit that referenced this pull request Mar 4, 2020
Closes #413
Closes #357

BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
kentcdodds pushed a commit that referenced this pull request Mar 12, 2020
Closes #413
Closes #357

BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
@kentcdodds kentcdodds restored the pr/remove-shim branch March 12, 2020 21:31
kentcdodds pushed a commit that referenced this pull request Mar 12, 2020
Closes #413
Closes #357

BREAKING CHANGE: MutationObserver is supported by all major browsers and recent versions of JSDOM. If you need, you can create your own shim (using @sheerun/mutationobserver-shim) and attach it to the window.
@kentcdodds kentcdodds deleted the pr/remove-shim branch March 12, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant