Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: destroy fixture in cleanup (#240) #241

Merged
merged 1 commit into from
Jul 30, 2021
Merged

feat: destroy fixture in cleanup (#240) #241

merged 1 commit into from
Jul 30, 2021

Conversation

Lukas-Kullmann
Copy link
Contributor

This change destroys the fixture (and in turn the components) after each test. This will prevent weird errors and free the components memory.

Fixes #240

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@timdeschryver
Copy link
Member

@all-contributors please add @Lukas-Kullmann for code

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @Lukas-Kullmann! 🎉

@timdeschryver timdeschryver merged commit dca7edd into testing-library:main Jul 30, 2021
@github-actions
Copy link

🎉 This PR is included in version 10.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fixture.destroy() not called in cleanup
2 participants