Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Jest 27 #232

Closed
wants to merge 3 commits into from
Closed

chore: upgrade to Jest 27 #232

wants to merge 3 commits into from

Conversation

nickserv
Copy link
Member

@nickserv nickserv commented Jul 1, 2021

I'm new to Nx and Angular and I've managed to migrate most of the way to Jest 27, but I'm stuck on some issues:

Lack of support for Jest's modern fake timers

ReferenceError: setImmediate is not defined

Deprecated setupFile configuration for Jest

Option "setupFile" is deprecated.

Linting problems

It seems like the migration for the eslintrc had a problem

> @testing-library/[email protected] lint
> nx workspace-lint && ng lint


Linting "example-app"...

/Users/nick/Repos/angular-testing-library/apps/example-app/src/app/examples/15-dialog.component.spec.ts
  57:3  error  Definition for rule 'testing-library/no-node-access' was not found  testing-library/no-node-access

✖ 1 problem (1 error, 0 warnings)

Lint errors found in the listed files.


Linting "example-app-karma"...

/Users/nick/Repos/angular-testing-library/apps/example-app-karma/src/environments/environment.prod.ts
  0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
The file does not match your project config: apps/example-app-karma/src/environments/environment.prod.ts.
The file must be included in at least one of the projects provided

✖ 1 problem (1 error, 0 warnings)

Lint errors found in the listed files.


Linting "jest-utils"...

All files pass linting.


Linting "testing-library"...

/Users/nick/Repos/angular-testing-library/projects/testing-library/tests/issues/issue-230.spec.ts
  2:1  error  Projects should use relative imports to import from other files within the same project. Use "./path/to/file" instead of import from "@testing-library/angular"  @nrwl/nx/enforce-module-boundaries

✖ 1 problem (1 error, 0 warnings)

Lint errors found in the listed files.

@timdeschryver
Copy link
Member

Hi @nickmccurdy I was working on the same task yesterday.
Therefore, I'm going to close this PR in favor of #233.

@nickserv nickserv deleted the jest-27 branch July 2, 2021 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants