Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TS config for tests of example-app-karma is broken #369

Closed
shaman-apprentice opened this issue Feb 19, 2023 · 0 comments · Fixed by #370
Closed

TS config for tests of example-app-karma is broken #369

shaman-apprentice opened this issue Feb 19, 2023 · 0 comments · Fixed by #370

Comments

@shaman-apprentice
Copy link
Contributor

Bug

Expected Behavior

GIVEN a fresh checkout of this repository with a fresh npm i
WHEN adding a debug console.log to a test from example-app-karma
THEN its tests pass

Actual Behavior

The tests fail to run, due to missing typescript types
Screenshot from 2023-02-19 11-27-59

Notes

  • Without any change the tests are not run due to cache
    tests from cache after npm i
  • Might be related to test not working #354?
  • I will prepare a PR to fix this
shaman-apprentice added a commit to shaman-apprentice/angular-testing-library that referenced this issue Feb 19, 2023
@shaman-apprentice
fix: add types for @testing-library/jasmine-dom
f5cfcdb 
ref testing-library#369
shaman-apprentice added a commit to shaman-apprentice/angular-testing-library that referenced this issue Feb 19, 2023
@shaman-apprentice
fix: add types for @testing-library/jasmine-dom
72e5e9a 
ref testing-library#369
@shaman-apprentice shaman-apprentice mentioned this issue Feb 19, 2023
Merged
timdeschryver pushed a commit that referenced this issue Feb 20, 2023
@shaman-apprentice
fix: add types for @testing-library/jasmine-dom (#370)
2006502 
Closes #369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add types for @testing-library/jasmine-dom shaman-apprentice/angular-testing-library
1 participant
@shaman-apprentice