-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce peer dependencies for easier integration #333
Comments
Ah yeah, good request, our team has the exact same problem. |
That seems reasonable. When that's done, I'll also take a look how to release a new version for |
through removing rxjs from peer dependencies ref testing-library#333
…in top of monorepo ref testing-library#333
🎉 This issue has been resolved in version 12.2.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
As a developer I want an easy integration into my project.
I am currently working on a project, which has some legacy dependencies which require
rxjs@6
as peer dependency and their update would be quite some work.This (awesome :) ) testing-library has
rxjs@7
as peer dependency declared here.This makes the dependency tree of the project invalid when integrating this testing library. I know that I can install nevertheless with
--legacy-peer-deps
but this looks like an awful error source to me.Would it be feasible for you to integrate
rxjs@7
as dev dependency? I see no hard downside in it? If you could also release it within@testing-library/angular@11
for Angular 13 support, that would be awesome for me.The text was updated successfully, but these errors were encountered: