Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce peer dependencies for easier integration #333

Closed
shaman-apprentice opened this issue Nov 28, 2022 · 3 comments · Fixed by #335
Closed

Reduce peer dependencies for easier integration #333

shaman-apprentice opened this issue Nov 28, 2022 · 3 comments · Fixed by #335
Labels

Comments

@shaman-apprentice
Copy link

shaman-apprentice commented Nov 28, 2022

As a developer I want an easy integration into my project.

I am currently working on a project, which has some legacy dependencies which require rxjs@6 as peer dependency and their update would be quite some work.

This (awesome :) ) testing-library has rxjs@7 as peer dependency declared here.

This makes the dependency tree of the project invalid when integrating this testing library. I know that I can install nevertheless with --legacy-peer-deps but this looks like an awful error source to me.

Would it be feasible for you to integrate rxjs@7 as dev dependency? I see no hard downside in it? If you could also release it within @testing-library/angular@11 for Angular 13 support, that would be awesome for me.

@knoffi
Copy link

knoffi commented Nov 28, 2022

Ah yeah, good request, our team has the exact same problem.

@timdeschryver
Copy link
Member

That seems reasonable.
Do you want to create a PR for this (v15 is planned to have the following rxjs dependencies "^6.5.3 || ^7.4.0")?

When that's done, I'll also take a look how to release a new version for @testing-library/angular@11 because I think I'll have to do that manually.

shaman-apprentice pushed a commit to shaman-apprentice/angular-testing-library that referenced this issue Dec 3, 2022
through removing rxjs from peer dependencies

ref testing-library#333
shaman-apprentice pushed a commit to shaman-apprentice/angular-testing-library that referenced this issue Dec 3, 2022
timdeschryver pushed a commit that referenced this issue Dec 3, 2022
@github-actions
Copy link

github-actions bot commented Dec 3, 2022

🎉 This issue has been resolved in version 12.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants