fix: support jest 27 #233
Merged
fix: support jest 27 #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickserv
requested changes
Jul 2, 2021
There was a problem hiding this comment.
I'm not familiar with the codebase, but the code looks good to me, and the upgrades seem to be working properly. Thanks for your help.
I think it would still be a good idea to remove the jest/no-done-callback ESLint rule from the config before merging, as Jest 27 requires you to either use done or async/await, and only using async/await would be more consistent and modern.
|
👍 I'm currently taking a look at the PR that you've created.
|
nickserv
approved these changes
Jul 4, 2021
|
Thanks @nickmccurdy |
|
🎉 This PR is included in version 10.9.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.