Fix #339: Add ChangeLog placeholder to fix symlink #362
Conversation
Running `python setup.py build_sphinx` will result in ChangeLog being overwritten with actual changes.
|
LGTM, thanks! |
|
@rbtcollins - any verification needed besides ensuring ChangeLog is overwritten after build? |
In order to use mock as a submodule, we can't rely on it being installed via pip, which pbr expects. This allows us to use mock in projects (gsutil, specifically) that may be installed via methods other than pip (git repo, tarball, etc.).
|
I'm not happy with the manual work that this will reintroduce around version management; like I said in #385 - Requirements: semver compatible versions for all git revs tl;dr definitely not going to use manual versioning, life is too short. If you reset this back to the first commit only, which was fine, we can merge it. |
|
Yep, I didn't intend to include the second change at the time I issued the pull request. We added that later after finding that some installation methods for gsutil (downloading via tarball, rather than installing with pip) would not include all necessary dependencies. Rather than include even more dependencies in the tarball, I just hard-coded the version in my fork we're using. |
Running
python setup.py build_sphinxwill result in ChangeLogbeing overwritten with actual changes.