fix(loader): make sure loaded status is only set on loader hook #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giltayar
suggested changes
Nov 27, 2022
Nkmol
force-pushed
the
fiix-isloaderloaded-for-mjs
branch
from
c3ba432
to
67c7cdb
Compare
|
LGTM. Thanks! |
|
Landed in 0.6.15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the
isLoadedstate is explicitly set through the NodeJS loader life-cycle, instead of through global/implicit imports of the file. This makes sure the state is only set when the file is loaded through a NodeJS loader.To not worry about unloaded/loading states, I simply separated the loader tests (MJS and JS) through two different
teenytestprocesses.fixes #77