Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala 3.0.0 #177

Merged
merged 4 commits into from
May 25, 2021
Merged

Scala 3.0.0 #177

merged 4 commits into from
May 25, 2021

Conversation

tpolecat
Copy link
Contributor

@tpolecat tpolecat commented May 5, 2021

This updates testcontainers to Scala 3.0.0-RC3 3.0.0.

@tpolecat
Copy link
Contributor Author

tpolecat commented May 5, 2021

There is a connection link failure that may be a timing issue. Re-run maybe?

@dimafeng
Copy link
Collaborator

dimafeng commented May 5, 2021

Looks like it. Re-running...

@tpolecat
Copy link
Contributor Author

tpolecat commented May 5, 2021

Sorry, I committed a metals file. Deleted.

@dimafeng
Copy link
Collaborator

dimafeng commented May 5, 2021

Hm, still failing with mysql test. I'll take a look over this week.

@tpolecat tpolecat mentioned this pull request May 7, 2021
1 task
@dimafeng
Copy link
Collaborator

dimafeng commented May 8, 2021

@tpolecat I suspect #178 should help. Can't reproduce this error locally.

@dimafeng
Copy link
Collaborator

dimafeng commented May 9, 2021

Turns out it's related to this testcontainers/testcontainers-java#4058

@dimafeng
Copy link
Collaborator

dimafeng commented May 9, 2021

@tpolecat I merged the fix for mysql spec to master. Would you mind merging it to your branch?

@tpolecat tpolecat force-pushed the scala-3.0.0-RC3 branch from c18a636 to a2f4643 Compare May 9, 2021 23:47
@tpolecat
Copy link
Contributor Author

tpolecat commented May 9, 2021

Ok I rebased.

@dimafeng
Copy link
Collaborator

dimafeng commented May 10, 2021

@tpolecat thanks! now it's failing with:

Uncaught exception when running com.dimafeng.testcontainers.integration.GenericContainerDockerFileSpec: java.lang.NoSuchMethodError: 'org.testcontainers.images.builder.traits.BuildContextBuilderTrait org.testcontainers.images.builder.ImageFromDockerfile.withFileFromClasspath(java.lang.String, java.lang.String)'

Do you think it's related to your change or it's new flakiness?

Anyways, I can try to dig into it in next few days.

@tpolecat
Copy link
Contributor Author

I saw this exception locally but it didn't happen initially in CI so I thought it was some local quirk. This should only be possible if we compile against one version and run against another (unless they're using reflection somewhere). The sbt eviction report shows nothing suspicious.

@tpolecat tpolecat changed the title Scala 3.0.0-RC3 Scala 3.0.0 May 14, 2021
@tpolecat
Copy link
Contributor Author

Went ahead and upgraded to 3.0.0

@dimafeng
Copy link
Collaborator

Hm, still the same error. I'm still trying to figure out why it's failing.

@milessabin
Copy link

Anything we can do to help?

@dimafeng
Copy link
Collaborator

Hi @milessabin, sorry, it has been a busy week and I haven't had a chance to take a look.
I'd appreciate any help with figuring out of the root cause of NoSuchMethodError.

@tpolecat
Copy link
Contributor Author

I'm going to dig into this today and see what I can figure out.

@tpolecat
Copy link
Contributor Author

tpolecat commented May 24, 2021

I narrowed it down to what I think is a compiler bug, here scala/scala3#12586. I will write a Java stub to work around it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants