Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: does not work with requests 2.32.0 #717

Closed
tristan957 opened this issue Oct 17, 2024 · 0 comments · Fixed by #718
Closed

Bug: does not work with requests 2.32.0 #717

tristan957 opened this issue Oct 17, 2024 · 0 comments · Fixed by #718

Comments

@tristan957
Copy link
Contributor

tristan957 commented Oct 17, 2024 •
edited
Loading

When trying to fetch a container, the following exception is raised:

requests.exceptions.InvalidURL: Not supported URL scheme http+docker

This issue is actually a docker-py issue: docker/docker-py#3256. As noted in docker/docker-py#3256 (comment), the release is part of 7.1.0 of docker-py. It seems like all we need to do is bump the docker-py version in the poetry.lock file. A new release after merging a PR would be awesome.
tristan957 added a commit to tristan957/testcontainers-python that referenced this issue Oct 17, 2024
@tristan957
Update docker to 7.1.0
98e86ff 
This allows testcontainers to work with requests >= 2.32.0.

Fixes: testcontainers#717
Link: docker/docker-py#3256
Link: docker/docker-py#3257
Link: docker/docker-py#3256 (comment)
Signed-off-by: Tristan Partin <[email protected]>
@tristan957 tristan957 mentioned this issue Oct 17, 2024
Merged
alexanderankin pushed a commit that referenced this issue Oct 23, 2024
@tristan957
chore: Update docker to 7.1.0 (#718)
fe489d7 
This allows testcontainers to work with requests >= 2.32.0.

Fixes:
#717
Link: docker/docker-py#3256
Link: docker/docker-py#3257
Link:
docker/docker-py#3256 (comment)

Signed-off-by: Tristan Partin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Update docker to 7.1.0 tristan957/testcontainers-python
1 participant
@tristan957