Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default client.ping.timeout value in docs #9464

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

KyleAure
Copy link
Contributor

Docs were never updated when the default value of client.ping.timeout was updated from 5 to 10 seconds.

public Integer getClientPingTimeout() {
return Integer.parseInt(getEnvVarOrProperty("client.ping.timeout", "10"));
}

@KyleAure KyleAure requested a review from a team as a code owner October 25, 2024 21:19
@eddumelendez eddumelendez changed the title doc: Default client.ping.timeout is incorrect in docs Fix default client.ping.timeout value in docs Oct 25, 2024
@eddumelendez eddumelendez added this to the next milestone Oct 25, 2024
@eddumelendez eddumelendez merged commit 77a423c into testcontainers:main Oct 25, 2024
8 checks passed
@eddumelendez
Copy link
Member

great catch, @KyleAure ! Thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants