Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use server URL from auth query if helper does not return one #9056

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Use server URL from auth query if helper does not return one #9056

merged 3 commits into from
Oct 15, 2024

Conversation

eager-signal
Copy link
Contributor

This fixes #9055.

@eager-signal eager-signal requested a review from a team as a code owner August 1, 2024 21:48
@eddumelendez eddumelendez added this to the next milestone Oct 15, 2024
@eddumelendez eddumelendez merged commit 5137472 into testcontainers:main Oct 15, 2024
103 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @eager-signal! and sorry for the delay. I confirmed looking at docker-credential-gcr and amazon-ecr-credential-helper

@eager-signal
Copy link
Contributor Author

@eddumelendez no problem at all—thank you!

@eager-signal eager-signal deleted the helper-empty-server-url branch October 15, 2024 14:28
@eddumelendez eddumelendez mentioned this pull request Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.20.3
2 participants
@eager-signal @eddumelendez