Correct testcontainers for use with latest MySQL 8.3 version #8131

chadlwilson · 2024-01-20T14:36:55Z

Fixes [Bug]: skip-host-cache option removed in latest MySQL 8.3.0 version #8130
Updates testing and doc defaults to be against non-EOL MySQL versions

Testcontainers default configuration no longer works with MySQL 8.3.0 since they have removed the skip-host-cache option which was deprecated in 8.0.30. This change replaces with host_cache_size = 0 which is equivalent and backward compatible back through previous releases (incl 5.7 and even 5.6).

This likely breaks for people that were depending on the rolling mysql:8 tag, since there is now a different release and LTS strategy which probably makes them more inclined to add breaking changes. 8.1 (Jun 2023) 8.2 (Oct 2023) and 8.3 (Dec 2023) have come in rapid succession as "innovation" releases with the new release strategy. Most users should probably be testing against mysql:8.0 tags so they stick to LTS, but that's probably a different concern :-)

To avoid regressions and refresh things, this PR updates the docs and mysql testing images accordingly based on https://endoflife.date/mysql

5.6 went EOL in Feb 2021. Stop testing against it, and remove references.
5.7 went EOL in Oct 2023. Retain tests for a bit, but stop using it as the default.
8.0.34+ is now LTS rather than rolling - use this as the default for most tests
Add 8.3.0 as a candidate "innovation" version to sanity test against. This could be periodically updated to stay ahead of the curve before the next LTS.

…ntainers#8130)

eddumelendez · 2024-01-22T23:14:54Z

Thanks for your contribution, @chadlwilson! I fixed the format and submit changes to your branch. However, test in MySQLJDBCDriverTest with URL jdbc:tc:mysql:8.0.36://hostname/databasename?TC_MY_CNF=somepath/mysql_conf_override is failing when using this config because innodb_file_format was removed in MySQL 8.

chadlwilson · 2024-01-23T02:27:05Z

Oh that's weird, I thought I'd run all the relevant tests locally and they were passing (although they are mysteriously slow with my Colima setup so maybe one got stuck and I didn't notice)

I'll take a look, sorry.

chadlwilson · 2024-01-23T05:22:27Z

Thanks @eddumelendez - rebased with your changes and fixed the failing test by switching to a new setting to validate config overrides. Should be OK now.

- 5.6 went EOL in Feb 2021. Stop testing against it. - 5.7 went EOL in Oct 2023. Retain tests for a bit, but stop using it as the default. - 8.0.34+ is now LTS rather than rolling - use this as the default for most tests - Add 8.3.0 as a candidate "innovation" version which will eventually become LTS Updates various docs to use 8.0 in the examples rather than EOL 5.7.

chadlwilson · 2024-01-23T16:07:49Z

Sigh; MariaDB test which shares the same test assertions should also be fixed now, although for some reason locally the MariaDB containers started by the tests just exit immediately and hang the tests so I can't verify.

(Edit: This is because the images the MariaDB tests are using are also ancient, not built for arm64, and crash under QEMU emulation on Apple Silicon. MariaDB really needs similar image refreshes, but will leave it out of the scope of this to fully update these, and just do the bare minimum to ensure they run on modern Macbooks.)

Previous images (10.2.x and 10.3.6) don't have ARM builds and otherwise crash under emulation on Apple Silicon machines. Updating accordingly is low risk even though a bigger refresh is needed.

eddumelendez

Thanks @chadlwilson! Just a few questions related to the default images used in MySQLContainer and MariaDBContainer.

eddumelendez · 2024-01-23T19:10:11Z

modules/mysql/src/main/java/org/testcontainers/containers/MySQLContainer.java

@@ -20,7 +20,7 @@ public class MySQLContainer<SELF extends MySQLContainer<SELF>> extends JdbcDatab
    private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("mysql");

    @Deprecated
-    public static final String DEFAULT_TAG = "5.7.34";
+    public static final String DEFAULT_TAG = "5.7.44";


Any issue is we keep 5.7.34 as a default? I would like to avoid breaking existing test that relies on default constructor.

I don't see why a patch/bugfix release would be expected to break things for people and if you check the history it was previously changed to a new patch releases.

For what it's worth here's an example:
3aa5fbf#diff-2568f90aa8a2109ff614414c5ef2b547f6bd7e8b8d4db9e81130d091b3e5d67cR19

eddumelendez · 2024-01-23T19:10:28Z

modules/mariadb/src/main/java/org/testcontainers/containers/MariaDBContainer.java

@@ -18,7 +18,7 @@ public class MariaDBContainer<SELF extends MariaDBContainer<SELF>> extends JdbcD
    private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse("mariadb");

    @Deprecated
-    public static final String DEFAULT_TAG = "10.3.6";
+    public static final String DEFAULT_TAG = "10.3.39";


Any issue is we keep 10.3.6 as a default? I would like to avoid breaking existing test that relies on default constructor.

Yes in fact, because 10.3.6 does not have ARM image variants and crashes when you try to run on Colima under emulation as noted in #8131 (comment)

10.3.39 with multiple archs: https://hub.docker.com/layers/library/mariadb/10.3.39/images/sha256-a4b57b620852e26f2c306c79fd8a61e22c7cd6e55d0a55d5521854ed2c370102?context=explore

10.3.6 with only amd64

https://hub.docker.com/layers/library/mariadb/10.3.6/images/sha256-ab3aab60f76b6d2d2e2d9d2c486029b63ad7cc9517ad4567a27c66999f8a23ce?context=explore

eddumelendez · 2024-01-23T22:48:53Z

Thanks for your contribution, @chadlwilson ! This is merged in main branch and it is part of the next release.

Remove use of deprecated (removed in 8.3) MySQL config option (testco…

12bf2f6

…ntainers#8130)

chadlwilson requested a review from a team as a code owner January 20, 2024 14:36

github-actions bot added type/docs modules/jdbc modules/spock Spock Extension modules/mysql labels Jan 20, 2024

mdelapenya mentioned this pull request Jan 20, 2024

fix: skip-host-cache option removed in latest MySQL 8.3.0 version testcontainers/testcontainers-go#2130

Merged

radovanradic referenced this pull request in micronaut-projects/micronaut-maven-plugin Jan 22, 2024

Switch to Postgres

37c1afc

radovanradic mentioned this pull request Jan 22, 2024

fix(deps): update dependency io.micronaut.flyway:micronaut-flyway-bom to v7 micronaut-projects/micronaut-r2dbc#569

Merged

1 task

aednichols mentioned this pull request Jan 22, 2024

WX-1385 Remove SAS tokens from TES input log printouts broadinstitute/cromwell#7358

Merged

eddumelendez added this to the next milestone Jan 22, 2024

eddumelendez added type/enhancement and removed type/docs labels Jan 22, 2024

chadlwilson force-pushed the fix-mysql-83 branch from 04979dc to faefdd6 Compare January 23, 2024 05:05

github-actions bot added the type/docs label Jan 23, 2024

chadlwilson force-pushed the fix-mysql-83 branch from faefdd6 to 00fcfe7 Compare January 23, 2024 05:16

chadlwilson force-pushed the fix-mysql-83 branch from 00fcfe7 to b4336df Compare January 23, 2024 15:16

chadlwilson force-pushed the fix-mysql-83 branch from b4336df to b936ec0 Compare January 23, 2024 15:56

github-actions bot added the modules/mariadb label Jan 23, 2024

Update MariaDB images to latest 10.3 patch release

a9d2270

Previous images (10.2.x and 10.3.6) don't have ARM builds and otherwise crash under emulation on Apple Silicon machines. Updating accordingly is low risk even though a bigger refresh is needed.

eddumelendez reviewed Jan 23, 2024

View reviewed changes

eddumelendez added 2 commits January 23, 2024 16:13

Keep default images

9b47a80

Merge branch 'main' into fix-mysql-83

2ea7fb5

eddumelendez approved these changes Jan 23, 2024

View reviewed changes

eddumelendez merged commit 9de26f1 into testcontainers:main Jan 23, 2024
88 checks passed

chadlwilson deleted the fix-mysql-83 branch January 24, 2024 02:00

sdelamo mentioned this pull request Jan 24, 2024

Investigate test-features failure in 4.2.x micronaut-projects/micronaut-starter#2278

Closed

jglick mentioned this pull request Jan 24, 2024

chore: temporarily pin mysql image to avoid test regressions jenkinsci/pipeline-maven-plugin#755

Merged

aednichols mentioned this pull request Jan 25, 2024

WX-1444 Use MySQL LTS in DBMS tests broadinstitute/cromwell#7360

Merged

santi mentioned this pull request Mar 30, 2024

RFC: 4.x releases testcontainers/testcontainers-python#446

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct testcontainers for use with latest MySQL 8.3 version #8131

Correct testcontainers for use with latest MySQL 8.3 version #8131

chadlwilson commented Jan 20, 2024

eddumelendez commented Jan 22, 2024

chadlwilson commented Jan 23, 2024

chadlwilson commented Jan 23, 2024

chadlwilson commented Jan 23, 2024 •

edited

Loading

eddumelendez left a comment

eddumelendez Jan 23, 2024

chadlwilson Jan 24, 2024

chadlwilson Jan 24, 2024

eddumelendez Jan 23, 2024

chadlwilson Jan 24, 2024

chadlwilson Jan 24, 2024 •

edited

Loading

eddumelendez commented Jan 23, 2024

Correct testcontainers for use with latest MySQL 8.3 version #8131

Correct testcontainers for use with latest MySQL 8.3 version #8131

Conversation

chadlwilson commented Jan 20, 2024

eddumelendez commented Jan 22, 2024

chadlwilson commented Jan 23, 2024

chadlwilson commented Jan 23, 2024

chadlwilson commented Jan 23, 2024 • edited Loading

eddumelendez left a comment

Choose a reason for hiding this comment

eddumelendez Jan 23, 2024

Choose a reason for hiding this comment

chadlwilson Jan 24, 2024

Choose a reason for hiding this comment

chadlwilson Jan 24, 2024

Choose a reason for hiding this comment

eddumelendez Jan 23, 2024

Choose a reason for hiding this comment

chadlwilson Jan 24, 2024

Choose a reason for hiding this comment

chadlwilson Jan 24, 2024 • edited Loading

Choose a reason for hiding this comment

eddumelendez commented Jan 23, 2024

chadlwilson commented Jan 23, 2024 •

edited

Loading

chadlwilson Jan 24, 2024 •

edited

Loading