Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark DockerMachineClientProviderStrategy as not persistable #593

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Mark DockerMachineClientProviderStrategy as not persistable #593

merged 2 commits into from
Feb 26, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Feb 25, 2018

No description provided.

@bsideup bsideup added this to the next milestone Feb 25, 2018
rnorth
rnorth requested changes Feb 25, 2018
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please could you update the changelog, then I think this is fine to merge!

@bsideup
Copy link
Member Author

bsideup commented Feb 25, 2018

@rnorth done :)

@bsideup bsideup closed this Feb 25, 2018
@bsideup bsideup reopened this Feb 25, 2018
@bsideup bsideup merged commit 6f151da into master Feb 26, 2018
@bsideup bsideup deleted the non_persistent_strategies branch February 26, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnorth rnorth rnorth requested changes

@kiview kiview kiview approved these changes

Assignees
No one assigned
Labels
client/docker-machine type/feature
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bsideup @rnorth @kiview