Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use version 1.2.3 of logback-classic to stay up to date #333

Merged
merged 2 commits into from
Apr 30, 2017

Conversation

dbyron0
Copy link
Contributor

@dbyron0 dbyron0 commented Apr 24, 2017

yet another dependency bump to keep up. See https://logback.qos.ch/news.html for background and https://docs.google.com/spreadsheets/d/1cpb5D7qnyye4W0RTlHUnXedYK98catNZytYIu5D91m0/edit#gid=0 for performance changes.

@rnorth
Copy link
Member

rnorth commented Apr 24, 2017

Travis failure looks unrelated - have retriggered.
Thanks for this.

@dbyron0
Copy link
Contributor Author

dbyron0 commented Apr 24, 2017

Glad the tests are passing.

@dbyron0
Copy link
Contributor Author

dbyron0 commented Apr 24, 2017

Happy to squash the commits when the time comes.

@rnorth
Copy link
Member

rnorth commented Apr 30, 2017

Squashing and merging - looks good to me. Thank you!

@rnorth rnorth merged commit b369ab3 into testcontainers:master Apr 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants