Simple summary logging of images pulled during execution #3165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another small mitigation for #3099: so that users have better visibility over number of images pulled during builds.
Produces an output like:
Conversely if no images have been pulled,
Testcontainers did not need to pull any images during execution
will be logged (for avoidance of doubt).For this change:
LoggedPullImageResultCallback
mechanism to record completed pullsI'm using String image names for this, but will raise a separate PR to refactor to use
DockerImageName
(that's a bit of a sprawling change).