Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Cassandra 4 support #7012

Closed
wakingrufus opened this issue May 5, 2023 · 5 comments · Fixed by #7013
Closed

[Enhancement]: Cassandra 4 support #7012

wakingrufus opened this issue May 5, 2023 · 5 comments · Fixed by #7013

Comments

@wakingrufus
Copy link
Contributor

Module

Cassandra

Proposal

I noticed the cassandra container only supports 2.x and 3.x. I'd like to see support for Cassandra server 4.x
I would be willing to help with this. I have experience getting cassandra 4 to run: jsevellec/cassandra-unit#325
but I am not familiar with testcontainer's code base.

@eddumelendez
Copy link
Member

Hi @wakingrufus, thanks for the offer! We already have tests running with Cassandra 4. or are you talking about the withInitScript() support?

@wakingrufus
Copy link
Contributor Author

wakingrufus commented May 5, 2023

Hi @wakingrufus, thanks for the offer! We already have tests running with Cassandra 4. or are you talking about the withInitScript() support?

I am not referring to cassandra datastax driver 4, but cassandra server 4

https://cassandra.apache.org/doc/4.0/cassandra/new/index.html

@eddumelendez
Copy link
Member

can you elaborate on what's missing in CassandraContainer to work with cassandra 4?

@wakingrufus
Copy link
Contributor Author

can you elaborate on what's missing in CassandraContainer to work with cassandra 4?

Im not sure, i just saw this:

Ill try using it with a casandra4 image and report back my results

wakingrufus added a commit to wakingrufus/testcontainers-java that referenced this issue May 5, 2023
update comment to reflect cassandra 4.x compatibility
fixes testcontainers#7012
@eddumelendez
Copy link
Member

Ill try using it with a casandra4 image and report back my results

Thank you!

wakingrufus added a commit to wakingrufus/testcontainers-java that referenced this issue May 5, 2023
add test against cassandra 4
update comment to reflect cassandra 4.x compatibility
fixes testcontainers#7012
eddumelendez added a commit that referenced this issue May 8, 2023
Fixes #7012


Co-authored-by: Eddú Meléndez Gonzales <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants