-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]: Update to LocalStack 2.x #6792
Comments
maybe this is the wrong place to point this out but would it be possible to make the configuration of the duration of the localstack startup configurable? I get a lot of problems when running it with the default timeout of 1 minute (maybe an issue in my infrastructure but I still would like to be able to configure it)
it does not matter if I use version 1.1, 1.2, 1.3 or 1.4 all of them give me consistent timeouts during start-up around 50% of the time |
@cstmgl I think so. This sounds like an unrelated feature request, so you should open a new issue. |
@laszlovandenhoek Thanks for sharing! I just started working on this and contacted the LocalStack team because found an issue. So, this will be take into account for next release. |
`HOSTNAME_EXTERNAL` env var is deprecated and will be replaced by `LOCALSTACK_HOST` in the upcoming v2. Fixes #6792
Module
LocalStack
Proposal
The current version of LocalStack is 1.4. The next release will be 2.0, due next week:
localstack/localstack#7882
This release contains changes that will break Testcontainers integration at some point in the future. In particular, the
HOSTNAME_EXTERNAL
environment variable that Testcontainers uses will be deprecated, to be replaced byLOCALSTACK_HOST
.In 2.0, the old
HOSTNAME_EXTERNAL
variable will continue working, so this will likely not start causing issues right away. But once this backwards-compatibility support is removed, thelocalstack/localstack:latest
Docker tag (effectively their nightly build) will immediately be updated.Therefore, people using Testcontainers with LocalStack using the
localstack:latest
will have their tests start failing at some point in the future. Even though using that tag is a bad idea, this likely applies to a non-trivial number of people, because the current default version is the ancient0.11.2
, and many fixes have been added to LocalStack since. That in itself is a good reason to update.The solution might be as simple as updating this constant (and checking all places that reference it):
testcontainers-java/modules/localstack/src/main/java/org/testcontainers/containers/localstack/LocalStackContainer.java
Line 33 in 3b0c1cb
The text was updated successfully, but these errors were encountered: