Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add support for CrateDB #6789

Closed
matriv opened this issue Mar 20, 2023 · 2 comments
Closed

[Feature]: Add support for CrateDB #6789

matriv opened this issue Mar 20, 2023 · 2 comments

Comments

@matriv
Copy link
Contributor

matriv commented Mar 20, 2023

Module

New Module

Problem

Currently CrateDB is not supported

Solution

Add support for CrateDB is not supported

Benefit

Be able to do integration testing with CrateDB through testcontainers

Alternatives

-none-

Would you like to help contributing this feature?

Yes

matriv added a commit to matriv/testcontainers-java that referenced this issue Mar 20, 2023
@eddumelendez
Copy link
Member

Hi @matriv, I see the PR was already created. So, there is no need for an issue. Also, next time please consider open a discussion first.

@matriv
Copy link
Contributor Author

matriv commented Mar 20, 2023

@eddumelendez Thank you!

Also, next time please consider open a discussion first.

Apologies, thought its was straightforward since I had a basic PR ready, and it's an addition of a new module.

matriv added a commit to matriv/testcontainers-java that referenced this issue Mar 20, 2023
matriv added a commit to matriv/testcontainers-java that referenced this issue Mar 20, 2023
matriv added a commit to matriv/testcontainers-java that referenced this issue Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants