-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider making the org.jetbrains:annotations dependency optional #3057
Labels
Milestone
Comments
16 tasks
@lukaseder thanks for reporting! We should definitely remove it as |
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
wpanas
added a commit
to wpanas/testcontainers-java
that referenced
this issue
Aug 26, 2020
rnorth
pushed a commit
that referenced
this issue
Sep 1, 2020
Co-authored-by: wpanas <[email protected]>
Fixed in #3157 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm assuming the
org.jetbrains:annotations
dependency is part of testcontainers because it improves Kotlin interoperability.I've discovered a rather annoying Eclipse IDE feature, where type annotations are always produced in generated code when using the IDE "quick fix" feature:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=565463
This is hardly ever useful or idiomatic in Java code. A workaround is to make the dependency optional:
https://stackoverflow.com/a/63131683/521799
I'm making this dependency optional in jOOQ 3.14 (jOOQ/jOOQ#6244), however, if someone depends on both jOOQ and testcontainers, the testcontainers transitive
org.jetbrains:annotations
dependency gets pulled in again, and the Eclipse IDE feature is active again.A workaround would be to do:
But I think the dependency could probably be made optional in testcontainers as well...?
The text was updated successfully, but these errors were encountered: