Update Javadocs

testcontainers · Oct 20, 2020 · f5498d5 · f5498d5
1 parent 58be3e0
commit f5498d5
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/core/src/main/java/org/testcontainers/utility/ConfigurationFileImageNameSubstitutor.java b/core/src/main/java/org/testcontainers/utility/ConfigurationFileImageNameSubstitutor.java
@@ -4,7 +4,8 @@
 import lombok.extern.slf4j.Slf4j;
 
 /**
- * TODO: Javadocs
+ * {@link ImageNameSubstitutor} which takes replacement image names from configuration.
+ * See {@link TestcontainersConfiguration} for the subset of image names which can be substituted using this mechanism.
  */
 @Slf4j
 public class ConfigurationFileImageNameSubstitutor extends ImageNameSubstitutor {

diff --git a/core/src/main/java/org/testcontainers/utility/DefaultImageNameSubstitutor.java b/core/src/main/java/org/testcontainers/utility/DefaultImageNameSubstitutor.java
@@ -4,7 +4,8 @@
 import lombok.extern.slf4j.Slf4j;
 
 /**
- * TODO: Javadocs
+ * Testcontainers' default implementation of {@link ImageNameSubstitutor}.
+ * Delegates to {@link ConfigurationFileImageNameSubstitutor} followed by {@link PrefixingImageNameSubstitutor}.
  */
 @Slf4j
 public class DefaultImageNameSubstitutor extends ImageNameSubstitutor {

diff --git a/core/src/main/java/org/testcontainers/utility/PrefixingImageNameSubstitutor.java b/core/src/main/java/org/testcontainers/utility/PrefixingImageNameSubstitutor.java
@@ -24,7 +24,7 @@ public class PrefixingImageNameSubstitutor extends ImageNameSubstitutor {
 
     @Override
     public DockerImageName apply(DockerImageName original) {
-        final String prefix = configuration.getEnvVarOrProperty(PROPERTY_KEY);
+        final String prefix = configuration.getEnvVarOrProperty(PROPERTY_KEY, "");
 
         if (prefix != null && !prefix.isEmpty()) {
             if (!original.asCanonicalNameString().startsWith(prefix)) {