feat: add Neo4j module #937
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Wow, great PR @fbiville! Thank you very much for your time. I'm only missing docs on the public API
What do you think if we add docs in the same way that we do for localstack or pulsar? I'd start using any of them as example, describing the different options:
- https://golang.testcontainers.org/modules/localstack/#module-reference
- https://golang.testcontainers.org/modules/pulsar/#container-options
Once there, I think this is ready to go! 🚀
|
I started with a minimal documentation page. Shall I complete the docs for the current feature set and work on the other features in subsequent PRs? |
As the neo4j module won't appear until the next release, I think it's fine to set this as ready-for-review and eventually merge this PR, and continue with the extensions in follow-up PRs. Thanks for contributing this module! Looks promising! |
|
I did not mention, but we are writing down a design doc for modules so, once approved, we will eventually update all existing modules to that design. This wants to reinforce the message of "progress, simple perfection" that I learnt at my time at Elastic :) So go for it adding incremental changes in small batches |
There was a problem hiding this comment.
LGTM! Thanks for the module for such a great technology!
As I said, we are planning to standardise how to create options, so we probably update the code in a follow-up PR with some design changes, but we prefer seeing progress here merging the PR and iterating in small chunks later. Will ping you in there.
Thanks again for your work in this PR
|
@mdelapenya now rebased |
|
Kudos, SonarCloud Quality Gate passed!
|
What does this PR do?
This introduces support for Neo4j containers.
Why is it important?
Neo4j is great database (I'm not biased at all /s) and deserves proper TestContainers support in Go.
Related issues