Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: support running MySQL compose tests in ARM #712

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It bumps the version of the MySQL docker image, from 5.7 to 8.

Why is it important?

mysql:5.7 does not have an ARM flavor, which makes impossible to run the tests locally on a Mac M1

mysql:5.7 does not have an ARM flavor
@mdelapenya mdelapenya requested a review from a team as a code owner December 23, 2022 18:12
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Dec 23, 2022
@mdelapenya mdelapenya self-assigned this Dec 23, 2022
@netlify
Copy link

netlify bot commented Dec 23, 2022

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 0954f08
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63a5ef8ff8849b00099991c1
😎 Deploy Preview https://deploy-preview-712--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya merged commit c2609c0 into testcontainers:main Dec 23, 2022
@mdelapenya mdelapenya changed the title chore: support running MySQL compose in ARM chore: support running MySQL compose tests in ARM Dec 23, 2022
@mdelapenya mdelapenya deleted the compose-tests-arm branch December 23, 2022 19:06
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jan 4, 2023
* main: (44 commits)
  feat: support passing registry credentials to the reaper (testcontainers#647)
  fix: close response body in http strategy (testcontainers#718)
  chore: move e2e module to postgres example module (testcontainers#717)
  chore: bump containerd transitive dep in examples (testcontainers#715)
  chore(deps): bump github.com/containerd/containerd from 1.6.12 to 1.6.14 (testcontainers#703)
  chore(deps): bump github.com/compose-spec/compose-go in /modules/compose (testcontainers#710)
  chore: bump testcontainers-go to 0.17.0 in examples (testcontainers#714)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#711)
  chore: support running MySQL compose in ARM (testcontainers#712)
  chore: simplify compose replace directives (testcontainers#713)
  chore: add compose module to dependabot (testcontainers#709)
  chore: move compose code to a separate module (testcontainers#650)
  docs: refine onboarding process with quickstart guide (testcontainers#706)
  chore: move redis-specific tests to the example module (testcontainers#701)
  chore: bump transitive dependencies (#527)
  chore: reduce concurrent builds (testcontainers#702)
  chore: add mysql example (testcontainers#700)
  chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (testcontainers#699)
  chore(deps): bump google.golang.org/api in /examples/firestore (testcontainers#683)
  chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#688)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant