Enable using stdin when starting docker compose #457
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
reviewed
Jun 13, 2022
compose.go
Outdated
| return err | ||
| } | ||
|
|
||
| file, err := ioutil.TempFile("/Users/aleksamalyshev/", "__tmp_") |
There was a problem hiding this comment.
I think this path is a leftover 😅
mdelapenya
reviewed
Jun 15, 2022
compose.go
Outdated
| return err | ||
| } | ||
|
|
||
| file, err := ioutil.TempFile("", "__tmp_") |
There was a problem hiding this comment.
Do you foresee any collision between multiple runs? Do you think we could use the compose identifier as part of the file name in that case 🤔?
| @@ -103,8 +104,16 @@ func NewLocalDockerCompose(filePaths []string, identifier string, opts ...LocalD | |||
|
|
|||
| dc.absComposeFilePaths = make([]string, len(filePaths)) | |||
| for i, cfp := range dc.ComposeFilePaths { | |||
| abs, _ := filepath.Abs(cfp) | |||
| dc.absComposeFilePaths[i] = abs | |||
| if cfp == "-" { | |||
There was a problem hiding this comment.
Mmm I do not get this line. Is it expected to receive a - as a file path for a compose file?
Co-authored-by: Manuel de la Peña <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #285