Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wait): strategy walk #2895

Merged
merged 4 commits into from
Nov 26, 2024
Merged

feat(wait): strategy walk #2895

merged 4 commits into from
Nov 26, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Nov 25, 2024

Add the Walk method which allows consumers to walk strategies and if desired update or remove them.

This is useful for modules which want to update strategy details based on user customisations performed by functional options passed to their run methods.

Add the Walk method which allows consumers to walk strategies and if
desired update or remove them.

This is useful for modules which want to update strategy details based
on user customisations performed by functional options passed to their
run methods.
Copy link

netlify bot commented Nov 25, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit bdf7c0f
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6745e96dc70d620008d79195
😎 Deploy Preview https://deploy-preview-2895--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenh stevenh marked this pull request as ready for review November 26, 2024 10:31
@stevenh stevenh requested a review from a team as a code owner November 26, 2024 10:31
@stevenh stevenh requested a review from mdelapenya November 26, 2024 10:31
docs/features/wait/walk.md Show resolved Hide resolved
docs/features/wait/walk.md Show resolved Hide resolved
@stevenh stevenh requested a review from mdelapenya November 26, 2024 13:31
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Nov 26, 2024
@mdelapenya mdelapenya added the enhancement New feature or request label Nov 26, 2024
@mdelapenya mdelapenya merged commit db43391 into main Nov 26, 2024
123 checks passed
@mdelapenya mdelapenya deleted the feat/wait-walk branch November 26, 2024 18:42
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 5, 2024
* main:
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
  chore(deps): bump actions/setup-go from 5.0.0 to 5.1.0 (testcontainers#2904)
  chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 (testcontainers#2903)
  chore(deps): bump test-summary/action from 2.3 to 2.4 (testcontainers#2902)
  feat(wait): strategy walk (testcontainers#2895)
  feat(wait): tls strategy (testcontainers#2896)
mdelapenya added a commit to mtellis2/testcontainers-go that referenced this pull request Dec 11, 2024
* main: (234 commits)
  chore(ci): add Github labels based on PR title (testcontainers#2914)
  chore(gha): Use official setup-docker-action (testcontainers#2913)
  chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911)
  feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905)
  chore: enable implicit default logger only in testing with -v (testcontainers#2877)
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
  chore(deps): bump actions/setup-go from 5.0.0 to 5.1.0 (testcontainers#2904)
  chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 (testcontainers#2903)
  chore(deps): bump test-summary/action from 2.3 to 2.4 (testcontainers#2902)
  feat(wait): strategy walk (testcontainers#2895)
  feat(wait): tls strategy (testcontainers#2896)
  docs: better contribution guidelines (testcontainers#2893)
  fix(influxdb): Respect custom waitStrategy (testcontainers#2845)
  fix: only upload to sonar on ubuntu-latest (testcontainers#2891)
  fix: build artifact name properly (testcontainers#2890)
  fix: do not run sonar upload when ryuk is disabled (testcontainers#2889)
  fix: update GH actions for uploading/downloading artifacts (testcontainers#2888)
  feat(ci): Enable master moby with rootless (testcontainers#2880)
  fix(redpanda): temporary file use
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants