fix: mongodb replicaset should work with auth #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
abhipranay
changed the title
mdelapenya
reviewed
Oct 23, 2024
mdelapenya
previously approved these changes
Oct 23, 2024
There was a problem hiding this comment.
LGTM, thanks for contributing the fix! Also for creating such a great commit history that allowed me to loop through it with ease.
@stevenh do you want to take a final look on it?
|
@abhipranay I added a commit on top with the fix for the lint: running |
mdelapenya
added a commit
that referenced
this pull request
Oct 28, 2024
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Oct 29, 2024
* main: chore: use require.Len instead of assert.Len (testcontainers#2854) chore: bump ryuk to 0.11.0 (testcontainers#2853) chore: enable usestdlibvars linter (testcontainers#2850) fix(compose): container initialisation (testcontainers#2844) fix!: data races (testcontainers#2843) fix: mongodb replicaset should work with auth (testcontainers#2847)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the bug for mongodb module where container doesn't start when
WithReplicaSetoption is used in combination withWithUsernameandWithPassword.Why is it important?
Fixes the issue mentioned in #2755.
Idea here is to use wrapping entrypoint so that security keyfile can be created with proper permissions and under correct ownership.
Wrapper entrypoint is used only when necessary and not always.
The functional option pattern make it difficult to figure out what were all the configured options so we are using
req.Envto share data across funtions.Related issues