Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add yugabytedb module #2825

Merged
merged 23 commits into from
Oct 18, 2024
Merged

feat: add yugabytedb module #2825

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
7436768
feat: add yugabytedb module
henripqt Oct 14, 2024
6f9a7ef
Merge branch 'main' into feat/add-yugabytedb-module
henripqt Oct 15, 2024
07674f5
fix: documentation links
henripqt Oct 15, 2024
084cde9
fix: codeinclude target
henripqt Oct 15, 2024
83a407f
feat: add test example for custom methods
henripqt Oct 15, 2024
6b09e71
Update modules/yugabytedb/yugabytedb_test.go
henripqt Oct 15, 2024
a51e4dd
Update modules/yugabytedb/yugabytedb.go
henripqt Oct 15, 2024
13cac89
Update modules/yugabytedb/yugabytedb_test.go
henripqt Oct 15, 2024
cad9e6a
fix: attended review issues
henripqt Oct 15, 2024
139f4d9
Update modules/yugabytedb/examples_test.go
henripqt Oct 16, 2024
2644453
fix: cleanup and review adjustements
henripqt Oct 16, 2024
4dea5ea
fix: remove test in comments and renamed struct
henripqt Oct 16, 2024
c556bd9
feat: add documentation for options
henripqt Oct 17, 2024
dcd9146
Merge branch 'main' into feat/add-yugabytedb-module
henripqt Oct 17, 2024
29ce547
Update modules/yugabytedb/yugabytedb_test.go
henripqt Oct 17, 2024
cb34dee
Update modules/yugabytedb/yugabytedb_test.go
henripqt Oct 17, 2024
fc9fc9c
fix: add additional wait strategy for data constraint log
henripqt Oct 17, 2024
d9d7aef
fix: remove customer method for ycql config and update test code
henripqt Oct 17, 2024
cd26ece
chore: run mod tidy
mdelapenya Oct 18, 2024
661dfec
chore: rename testable example to fix lint
mdelapenya Oct 18, 2024
d253ff8
fix: wrong cluster addr in example test
henripqt Oct 18, 2024
f31f993
Merge branch 'main' into feat/add-yugabytedb-module
henripqt Oct 18, 2024
2d7a7c7
fix: update code snippet run example
mdelapenya Oct 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/yugabytedb/examples_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,10 @@ func ExampleContainer_YCQLConfigureClusterConfig() {
}()

cluster := gocql.NewCluster()
yugabytedbContainer.YCQLConfigureClusterConfig(ctx, cluster)
if err := yugabytedbContainer.YCQLConfigureClusterConfig(ctx, cluster); err != nil {
log.Printf("failed to configure cluster: %s", err)
return
}

session, err := cluster.CreateSession()
if err != nil {
Expand Down
1 change: 1 addition & 0 deletions modules/yugabytedb/yugabytedb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ func Run(ctx context.Context, img string, opts ...testcontainers.ContainerCustom
Cmd: []string{"bin/yugabyted", "start", "--background=false"},
WaitingFor: wait.ForAll(
wait.ForLog("YugabyteDB Started").WithOccurrence(1),
wait.ForLog("Data placement constraint successfully verified").WithOccurrence(1),
henripqt marked this conversation as resolved.
Show resolved Hide resolved
wait.ForListeningPort(ysqlPort),
wait.ForListeningPort(ycqlPort),
),
Expand Down