Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if the discovered docker socket responds #2741
fix: check if the discovered docker socket responds #2741
Changes from 11 commits
19fb55b
fbadada
c6c4832
ff83aff
270c2b6
cdb3825
42a77dd
64c4d2d
e8eeff3
da6d2b1
8dd2979
320ac54
94b661d
d29de5e
c4546f6
b493c72
5a234fe
38720a3
1da780c
2472045
1f3c6d9
311507e
50d424f
f030b5c
8cbe4e6
9dfd4fb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: This results in
ExtractDockerSocket
panic which is used in other non internal functions including its namesakeExtractDockerSocket
none of which mention they can panic.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added comments to the functions, could you please check that? 🙏