Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(elasticsearch): wait for #2724

Merged
merged 1 commit into from
Sep 27, 2024

Conversation

stevenh
Copy link
Collaborator

@stevenh stevenh commented Aug 8, 2024

Wait for the HTTP port to be available to prevent random failures when the container isn't fully started and returns 503 errors.

@stevenh stevenh requested a review from a team as a code owner August 8, 2024 19:16
Copy link

netlify bot commented Aug 8, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit b04d5c9
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/66f5a36a37f5b6000874c450
😎 Deploy Preview https://deploy-preview-2724--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing test, LGTM. Once added, I think this is ready to go.

Thanks!

@stevenh stevenh mentioned this pull request Aug 12, 2024
@stevenh
Copy link
Collaborator Author

stevenh commented Aug 12, 2024

Apart from the missing test, LGTM. Once added, I think this is ready to go.

Thanks!

This is actually a bug, I missed the circular dependency between the ready and wait conditions.

There's two options:

  1. Just use insecure for SSL check
  2. Refactor to a wait on the file using feat(wait): for file #2731

@stevenh stevenh force-pushed the fix/elasticsearch-wait branch 2 times, most recently from 47902f6 to 0753e11 Compare September 10, 2024 10:32
@stevenh stevenh marked this pull request as draft September 10, 2024 10:32
@stevenh stevenh force-pushed the fix/elasticsearch-wait branch from 0753e11 to 7eeb3a5 Compare September 10, 2024 11:32
@stevenh stevenh requested a review from mdelapenya September 10, 2024 12:45
@stevenh stevenh marked this pull request as ready for review September 10, 2024 12:45
@stevenh
Copy link
Collaborator Author

stevenh commented Sep 10, 2024

@mdelapenya rebased on top of the new wait.ForFile so ready fore review now.

mdelapenya
mdelapenya previously approved these changes Sep 26, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is just one comment regarding adding the basic auth to the wait strategy twice.

Other than that, LGTM, thanks!

Wait for the HTTP port to be available to prevent random failures when
the container isn't fully started and returns 503 errors.
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya mdelapenya self-assigned this Sep 27, 2024
@mdelapenya mdelapenya added the bug An issue with the library label Sep 27, 2024
@mdelapenya mdelapenya merged commit 4dc3662 into testcontainers:main Sep 27, 2024
114 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 27, 2024
* main:
  fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Sep 27, 2024
* main:
  fix(redpanda): wait for (testcontainers#2794)
  fix(elasticsearch): wait for (testcontainers#2724)
mdelapenya added a commit that referenced this pull request Oct 17, 2024
* main:
  chore: replace 'assert' with 'require' (#2827)
  chore: replace 'assert' with 'require' for critical checks (#2824)
  chore: bump ryuk to latest release (#2818)
  feat: add require for critical checks (#2812)
  chore(deps): bump release-drafter/release-drafter from 5.25.0 to 6.0.0 (#2805)
  feat: add etcd module (#2788)
  feat: add dynamodb-local module (#2799)
  fix(redpanda): wait for (#2794)
  fix(elasticsearch): wait for (#2724)
  chore: update dockercfg module (#2801)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants