Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: run rootless mode in nighlty builds #2611

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR updates the nightly build that uses the TEST channel of the Docker builds, so that we are able to run the nightly build for rootful and rootless mode.

Why is it important?

We want to detect regressions the soonest.

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner June 27, 2024 15:16
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality github_actions Pull requests that update GitHub Actions code labels Jun 27, 2024
@mdelapenya mdelapenya self-assigned this Jun 27, 2024
Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 2d0077b
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/667d8254e233af0008249dac
😎 Deploy Preview https://deploy-preview-2611--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya
Copy link
Member Author

Merging, as there is no code related to the tests. The current failures in rootless mode are precisely the ones we want to proactively discover in this nightly build.

@mdelapenya mdelapenya merged commit 4b0a7ec into testcontainers:main Jun 27, 2024
102 of 105 checks passed
@mdelapenya mdelapenya deleted the run-rootless-nightly branch June 27, 2024 15:36
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jun 27, 2024
* main:
  chore: run rootless mode in nighlty builds (testcontainers#2611)
mdelapenya added a commit that referenced this pull request Jun 28, 2024
* main:
  chore(ci): pass docker install type to the nightly build payload (#2612)
  chore: run rootless mode in nighlty builds (#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (#2605)
  chore: improve log handling when container is stopping (#2601)
mdelapenya added a commit to thaJeztah/testcontainers-go that referenced this pull request Jun 28, 2024
* main:
  chore: test cleanups (testcontainers#2608)
  chore(ci): pass docker install type to the nightly build payload (testcontainers#2612)
  chore: run rootless mode in nighlty builds (testcontainers#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605)
  chore: improve log handling when container is stopping (testcontainers#2601)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jul 2, 2024
* main:
  chore(deps): bump github.com/docker/docker from v26.1.4 to v27.0.2 (testcontainers#2593)
  fix: Rename TC_HOST environment variable to TESTCONTAINERS_HOST_OVERRIDE (testcontainers#2536)
  chore: test cleanups (testcontainers#2608)
  chore(ci): pass docker install type to the nightly build payload (testcontainers#2612)
  chore: run rootless mode in nighlty builds (testcontainers#2611)
  chore(deps): bump github.com/hashicorp/go-retryablehttp (testcontainers#2605)
  chore: improve log handling when container is stopping (testcontainers#2601)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant