Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(postgres): ssl for postgres #2473
base: main
Are you sure you want to change the base?
feat(postgres): ssl for postgres #2473
Changes from 31 commits
daa8cf2
53e2135
bd3360d
c3fd69b
445a575
8814e8c
2aecc1b
eac665d
302472c
3099790
e067d0f
2c7f621
b9cd59b
ef017c9
fd3d3e5
cd1b63f
c7eebeb
a36eafa
7ea323a
0557c9d
5d0fa1e
7805e1f
c80fa83
e73f9a5
1be6a31
4e6c6d7
e28361a
8502649
5d8598f
dffe996
53d9a1a
146f47d
94bd7f4
dfa322e
18ab8b7
ab0e3ff
9e15ac5
c1cda1e
3dfb0cb
ff6ce3e
6adf44c
6fb5455
81a8d18
e980a90
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I don't believe this is needed as it would caught by the copy handler, see full suggestion below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you considered using tlscert.SelfSignedCA here instead? See https://github.com/mdelapenya/tlscert/blob/a038576e80ef259d2a60317ab51e37cdda8da3c8/tlscert.go#L135
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: use
ContainerCleanup
followed byrequire.NoError
to ensure the container is removed correctlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bug: missing
ContainerCleanup
call