Fix: HTTP wait strategy does not take query params into account #2466
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When specifying a wait strategy using HTTP with query params, they are not sent to the container.
For example, to ensure the elasticmq container is ready, as advised in this issue, one must
poll the
/?Action=ListQueues
endpoint.Currently this returns a 400 Bad request because the query parameters are not sent correctly to the endpoint.
The way the fix work is to parse the given path to create a
url.URL
instance and update the fields with the other values. This way the query parameters and the path are correclty handled.Why is it important?
Related issues
Here is a reproduction with the elasticmq container: