Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for waiting for response headers #2349

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR supports passing HTTP headers to the wait.ForHTTP strategy, including a matcher for response header.

Why is it important?

We would want to wait for a certain HTTP response header to be added to a response, or we would want to pass HTTP headers to the wait strategy, and that was not possible.

@mdelapenya mdelapenya added the enhancement New feature or request label Mar 13, 2024
@mdelapenya mdelapenya self-assigned this Mar 13, 2024
@mdelapenya mdelapenya requested a review from a team as a code owner March 13, 2024 13:27
Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit a723e93
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/65f1a9dfa5a6850008e766d2
😎 Deploy Preview https://deploy-preview-2349--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdelapenya mdelapenya merged commit 0f364a3 into testcontainers:main Mar 14, 2024
98 checks passed
mdelapenya added a commit to JJCinAZ/testcontainers-go that referenced this pull request Mar 15, 2024
* main:
  feat: support for waiting for response headers (testcontainers#2349)
  chore(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0 (testcontainers#2392)
  redpanda: set entrypoint to the custom entrypoint file (testcontainers#2347)
@mdelapenya mdelapenya deleted the wait-for-http-headers branch March 19, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant