feat: add kafka (KRaft mode only) module #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
48 tasks
* main: chore: always generate the examples including a explicit image (testcontainers#1611) chore: support linting all modules locally (testcontainers#1609)
mdelapenya
changed the title
|
@eddumelendez if you agree I0d like to proceed and merge this module, as it's clear that it uses kafka + KRaft. We can listen to the future feedback in the case we need to add support for Zookeeper mode. Thoughts? |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 18, 2023
* main: feat: add kafka (KRaft mode only) module (testcontainers#1610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a Kafka module, as a result of updating #1034 by @noctarius to the new design for modules.
The module comes with:
We copied the Java module implementation, but providing support for KRaft-only:
Why is it important?
A new module for a technology that is widely used
Related issues