ci(lint): enable gocritic linter #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Matthieu MOREL <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
mdelapenya
pushed a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 11, 2023
Signed-off-by: Matthieu MOREL <[email protected]>
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 11, 2023
* main: ci(lint): enable errorlint linter (testcontainers#1604) ci(lint): enable gocritic linter (testcontainers#1605) chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566)
mdelapenya
added a commit
that referenced
this pull request
Sep 11, 2023
* fix: rename vault container in tests * chore: adjust comment in template * docs(vault): use RunContainer example in usage section * docs: update vault docs * docs: add RunContainer example for redpanda * docs: add RunContainer example for redis * docs: document creating networks * docs: add RunContainer example for pulsar * docs: add RunContainer example for postgres * docs: add RunContainer example for neo4j * docs: add RunContainer example for nats * docs: update quickstart to not use testing libraries * docs: add RunContainer example for mysql * docs: add RunContainer example for mongo * docs: add RunContainer example for mariadb * chore: use logger to print out hostname external reason * docs: document new Go examples file * docs: add RunContainer example for localstack * chore: convert k3s test into a testable example * chore: convert mongodb test into testable example * fix: handle errors in example tests for elasticsearch * fix: do not deprecate used fields They are not directly called, but the customisers are populating their values * chore: convert couchbase test into testable example * chore: convert clickhouse test into testable example * docs: adjust artemis docs * chore: simplify postgres example * fix: lint * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (#1566) * chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault Bumps [github.com/hashicorp/vault-client-go](https://github.com/hashicorp/vault-client-go) from 0.2.0 to 0.3.3. - [Release notes](https://github.com/hashicorp/vault-client-go/releases) - [Changelog](https://github.com/hashicorp/vault-client-go/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault-client-go@v0.2.0...v0.3.3) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault-client-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * up * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go * Update vault_test.go --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel de la Peña <[email protected]> * ci(lint): enable gocritic linter (#1605) Signed-off-by: Matthieu MOREL <[email protected]> * ci(lint): enable errorlint linter (#1604) * ci(lint): enable errorlint linter Signed-off-by: Matthieu MOREL <[email protected]> * Apply suggestions from code review Co-authored-by: Manuel de la Peña <[email protected]> --------- Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Manuel de la Peña <[email protected]> * fix: handle errors * chore(pulsar): create/remove the network properly * chore: better container logs on errors during startup * Revert "chore: better container logs on errors during startup" This reverts commit 0e28881. * chore: better container logs on errors during startup * fix: do not wrap error but print it * fix: avoid polluting default wait strategies in pulsar --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Matthieu MOREL <[email protected]> Co-authored-by: Matthieu MOREL <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Sep 12, 2023
* main: chore: always generate the examples including a explicit image (testcontainers#1611) chore: support linting all modules locally (testcontainers#1609) ci(sonarcloud): run only when not root-less (testcontainers#1608) remove extra equal in sonar.organization (testcontainers#1607) chore(ci): enable code coverage on Sonarcloud (testcontainers#1518) docs: use Go testable examples in modules (testcontainers#1603) ci(lint): enable errorlint linter (testcontainers#1604) ci(lint): enable gocritic linter (testcontainers#1605) chore(deps): bump github.com/hashicorp/vault-client-go in /modules/vault (testcontainers#1566) ci(security): setup codeql scan (testcontainers#1606) chore(deps): bump github.com/cyphar/filepath-securejoin (testcontainers#1601) chore: generate Go examples for new modules (testcontainers#1600) chore: generate Go examples for new modules (testcontainers#1600)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables gocritic linter
Why is it important?
Provides diagnostics that check for bugs, performance and style issues.
Extensible without recompilation through dynamic rules.
Dynamic rules are written declaratively with AST patterns, filters, report message and optional suggestion.