Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct path for gotestsum output #1287

Merged
merged 6 commits into from
Jun 19, 2023
Merged

fix: use correct path for gotestsum output #1287

merged 6 commits into from
Jun 19, 2023

Conversation

sebastianbuechler
Copy link
Contributor

@sebastianbuechler sebastianbuechler commented Jun 14, 2023 •
edited by mdelapenya
Loading

What does this PR do?

Use the correct path for the gotestsum output in the module-postgres pipeline

Why is it important?

It's broken.

Related issues

How to test this PR

Check module-postgres pipeline

Follow-ups

If this fix works we can check other pipelines as well if they need a fix too.

@sebastianbuechler sebastianbuechler requested a review from a team as a code owner June 14, 2023 20:29
@netlify
Copy link

netlify bot commented Jun 14, 2023 •
edited
Loading

✅ Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 0325c78
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/648c238b08d96700086f803b
😎 Deploy Preview https://deploy-preview-1287--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

This was referenced Jun 14, 2023
Closed
Closed
mdelapenya
mdelapenya reviewed Jun 15, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the final approval to the rollback of the indents, but other than that, LGTM! Thanks for the quick fix! 👏

@sebastianbuechler
Copy link
Contributor Author

Pending the final approval to the rollback of the indents, but other than that, LGTM! Thanks for the quick fix! 👏

Reverted the linting. Thanks for the package!

@mdelapenya
Copy link
Member

The unit test that is failing is https://github.com/testcontainers/testcontainers-go/blob/main/modulegen/main_test.go#LL479C46-L479C55

It covers that the templates are properly rendered for each module. Would you mind updating the test too? 🙏

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

mdelapenya
mdelapenya approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for detecting this subtle bug and proposing a quick fix! Much appreciated 👏

@mdelapenya mdelapenya self-assigned this Jun 19, 2023
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Jun 19, 2023
@mdelapenya mdelapenya merged commit e1c381f into testcontainers:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: CI Pipeline reports wrong test outputs
2 participants
@sebastianbuechler @mdelapenya