fix: return proper docker socket for remote Docker hosts #1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
cristianrgreco
approved these changes
Jun 13, 2023
mdelapenya
added a commit
that referenced
this pull request
Jun 13, 2023
….5.0 * main: chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (#1271) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (#1265) chore(deps): bump google.golang.org/api from 0.124.0 to 0.125.0 in /examples (#1284) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (#1283) chore(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#1282) fix: return proper docker socket for remote Docker hosts (#1281) Update java docs domain (#1279)
mdelapenya
added a commit
that referenced
this pull request
Jun 13, 2023
…er-24.0.2incompatible * main: chore(deps): bump github.com/aws/aws-sdk-go in /modules/localstack (#1271) chore(deps): bump github.com/neo4j/neo4j-go-driver/v5 in /modules/neo4j (#1265) chore(deps): bump google.golang.org/api from 0.124.0 to 0.125.0 in /examples (#1284) chore(deps): bump github.com/twmb/franz-go in /modules/redpanda (#1283) chore(deps): bump github.com/stretchr/testify from 1.8.3 to 1.8.4 (#1282) fix: return proper docker socket for remote Docker hosts (#1281) Update java docs domain (#1279)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PRs returns the default Docker host in the case the
tc.hostproperty is foundWhy is it important?
In #1161, we improved the resolution of the Docker socket depending on multiple scenarios (docker rootless, using a remote host, etc) but in the case the
tc.hostproperty is found, it simply returned it as the Docker socket path, which is incorrect. Instead, we must return the default docker socket path (/var/run/docker.sock)Related issues