feat: adds k3s module #1194
Merged
feat: adds k3s module #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mritunjay <[email protected]>
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
reviewed
May 17, 2023
mdelapenya
reviewed
May 17, 2023
mdelapenya
reviewed
May 17, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 17, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 19, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 20, 2023
mdelapenya
reviewed
May 20, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 20, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 22, 2023
Signed-off-by: Mritunjay <[email protected]>
mdelapenya
reviewed
May 23, 2023
Signed-off-by: Mritunjay <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks a lot @mdelapenya for the amazing reviews and suggestions, just improved the doc as suggested, let's hope it looks good now, ping me for any other improvements 🙏 |
mdelapenya
approved these changes
May 23, 2023
48 tasks
mdelapenya
reviewed
May 23, 2023
|
@mritunjaysharma394 I'm creating a K3s module for NodeJS and I'm looking at the three existing implementations: testcontainers/testcontainers-node#863 I noticed that this golang version does not bind mount Why is this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds k3s modules for golang testcontainers
Why is it important?
It is important as part of a task of #636 to support k3s modules too.
Related issues
Relates to #636