Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#98 canned postgres #117

Closed
wants to merge 4 commits into from
Closed

#98 canned postgres #117

wants to merge 4 commits into from

Conversation

nikolayk812
Copy link

  • no postgres client exposed to API
  • less code

@nikolayk812
Copy link
Author

Defintely inspired by @giorgioazzinnaro

@nikolayk812 nikolayk812 mentioned this pull request Dec 1, 2019
Closed
borgotta
borgotta reviewed Dec 4, 2019
View reviewed changes
canned/postgres/postgres.go

const (
image = "postgres"
tag = "9.6.15"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think that it will be better if we use some fresher versions by default? Like 12.1-alpine, for example.

@DerThorsten
Copy link

Will this be merged ? is there anything where I could help to get this merged?

@Streppel
Copy link

Streppel commented May 4, 2020

I second @DerThorsten . I can help too if needed.

@gianarb gianarb mentioned this pull request Nov 20, 2020
Merged
@gianarb gianarb closed this in #268 Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@borgotta borgotta borgotta left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikolayk812 @DerThorsten @Streppel @borgotta