"go get" failure parsing go.mod file

[vangent]

I have an implicit dependency on this project and when I run go get -u, I get this error:

go: github.com/testcontainers/[email protected]: parsing go.mod: unexpected module path "github.com/testcontainers/testcontainers-go"

[MeneDev]

I have an implicit dependency on this project and when I run go get -u, I get this error: ...

@vangent it was renamed from testcontainer to testcontainers (Plural) for consistency reasons.

What's the other project you depend on? I think the right solution would be changing the dependency there. As a quick fix you should be able to override the path in the config of your dependency manager (e.g. Gopkg).

_{Sent with GitHawk}

[vangent]

I don't know which of my dependencies depend on you. I couldn't tell because "go mod why" failed with the same error. Regardless, I don't own any of them so I couldn't have updated it anyway.

I'm using Go Modules, not a specific dependency manager.

This may just be a side effect of your making a non-backward compatible change, and Go Modules not handling it well.

[VoyTechnology]

As a temporary workaround you can do this:

in go.mod file:

replace github.com/testcontainers/testcontainer-go => github.com/testcontainers/testcontainers-go v0.0.0-20190108154635-47c0da630f72

It looks like go modules only like tag names with v prefix, so the current 0.0.1 tag does not work. The authors need to re-tag it with v0.0.1.

Thanks to @F21: golang/go#26904 (comment)

[gianarb]

Thanks @VoyTechnology I was just looking for that trick!
@vangent sorry about this bad bc break, but changing the name to keep it consistent was kind of a requirement. I hope you will find the library good and you will give it a try!
If the fix works and you are able to understand what project injects our library let me know we will submit a pr to fix it

[vangent]

Thanks for the tips. It sounds like the only action item for the library author is to retag the release with v0.0.1 instead of 0.0.1, to work well with Go Modules.

[VoyTechnology]

I think it would be part of the solution, but also finding any libraries which depend on the old version before rename and filing PRs to update them.

[vangent]

It looks like my problem came from hashicorp -> influxdb:
influxdata/influxdb#11199

[prologic]

I'm running into this as well from micro/go-plugins#290 :

go: github.com/testcontainers/[email protected]: parsing go.mod: unexpected module path "github.com/testcontainers/testcontainers-go"

[gianarb]

Hello! Yes! I will work on that asap! Thanks

…

On Wed, Feb 27, 2019 at 6:55 AM Guan Gui ***@***.***> wrote: can you fix this? so annoying — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjgO2rYCnXfWLqn0ILTWOY3edK4aCBkks5vRh3MgaJpZM4aNqL2> .

-- Gianluca Arbezzano www.gianarb.it

[guiguan]

@gianarb it looks like a dependency is expecting github.com/testcontainers/testcontainer-go instead of github.com/testcontainers/testcontainers-go when building gocloud.dev. Probably because you renamed the repo. Strange enough, I couldn't use go mod why to figure which sub-module is expecting that. The replace workaround works. Thanks!

[prologic]

What's the hold-up of getting this fixed for this repo? Can we just re-tag this repo appropriately and move on?

[guiguan]

@prologic I think the real problem is not about the tag, but other packages are still using this repo’s old name, the one without s

[prologic]

Oh I see let me. Erich yny did micro/go-plugins

On Tue, 5 Mar 2019 at 13:11, Guan Gui ***@***.***> wrote: @prologic <https://github.com/prologic> I think the real problem is not about the tag, but other packages are still using this repo’s old name, the one without s — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABOv-pkEkO1QZWOC_VLy4mnCYHor7Niwks5vTeBTgaJpZM4aNqL2> .

-- James Mills / prologic E: [email protected] W: prologic.shortcircuit.net.au

[gianarb]

There is not a lot that I can do about this issue btw.
Or is somebody has idea just let me know
atm I tagged 0.0.2 and we need to figure out who is using the old name

[VoyTechnology]

Please please please re-tag with v prefix. v0.0.2

[gianarb]

Done

…

On Thu, Mar 7, 2019 at 11:20 PM Wojtek Bednarzak ***@***.***> wrote: Please please please re-tag with v prefix. v0.0.2 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjgO5uCfQTM9PQg6_xyTUIIDX5KsPtZks5vUYKDgaJpZM4aNqL2> .

-- Gianluca Arbezzano www.gianarb.it

[gianarb]

I think we are good for now, And I am gonna keep tagging with the v in front. Sorry about this mess. Closing for now