fix(compose): avoid race conditions when caching services

testcontainers · May 3, 2024 · d702774 · d702774
1 parent da2d5c5
commit d702774
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/modules/compose/compose_api.go b/modules/compose/compose_api.go
@@ -370,6 +370,8 @@ func (d *dockerCompose) Up(ctx context.Context, opts ...StackUpOption) error {
 				}()
 			}
 
+			d.containersLock.Lock()
+			defer d.containersLock.Unlock()
 			d.containers[srv.Name] = dc
 
 			return nil
@@ -398,6 +400,8 @@ func (d *dockerCompose) Up(ctx context.Context, opts ...StackUpOption) error {
 			}
 
 			// cache all the containers on compose.up
+			d.containersLock.Lock()
+			defer d.containersLock.Unlock()
 			d.containers[svc] = target
 
 			return strategy.WaitUntilReady(errGrpCtx, target)