Apply suggestions from code review

Co-authored-by: Manuel de la Peña <[email protected]>
testcontainers · Sep 11, 2023 · 77b5d25 · 77b5d25
1 parent 5565e4d
commit 77b5d25
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/docker.go b/docker.go
@@ -795,7 +795,7 @@ func (p *DockerProvider) BuildImage(ctx context.Context, img ImageBuildInfo) (st
 		resp, err = p.client.ImageBuild(ctx, buildContext, buildOptions)
 		if err != nil {
 			var enf errdefs.ErrNotFound
-			if ok := errors.As(err, &enf); ok {
+			if errors.As(err, &enf) {
 				return backoff.Permanent(err)
 			}
 			Logger.Printf("Failed to build image: %s, will retry", err)
@@ -1163,7 +1163,7 @@ func (p *DockerProvider) attemptToPullImage(ctx context.Context, tag string, pul
 		pull, err = p.client.ImagePull(ctx, tag, pullOpt)
 		if err != nil {
 			var enf errdefs.ErrNotFound
-			if ok := errors.As(err, &enf); ok {
+			if errors.As(err, &enf) {
 				return backoff.Permanent(err)
 			}
 			Logger.Printf("Failed to pull image: %s, will retry", err)

diff --git a/wait/host_port.go b/wait/host_port.go
@@ -156,9 +156,9 @@ func externalCheck(ctx context.Context, ipAddress string, port nat.Port, target
 		conn, err := dialer.DialContext(ctx, proto, address)
 		if err != nil {
 			var v *net.OpError
-			if ok := errors.As(err, &v); ok {
+			if errors.As(err, &v) {
 				var v2 *os.SyscallError
-				if ok := errors.As(v.Err, &v2); ok {
+				if errors.As(v.Err, &v2) {
 					if isConnRefusedErr(v2.Err) {
 						time.Sleep(waitInterval)
 						continue