Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add LocalStack module #773

Merged
merged 28 commits into from
Feb 13, 2023

Conversation

dominikus1993
Copy link
Contributor

What does this PR do?
Add support for amazon LocalStack testcontainer module.

Why is it important?
I think that adding this testcontainer will be useful for developers who want to test the operation of multiple aws modules

Related issues
Any of issues are no releated

How to test this PR
Running the new integration test will suffice.

@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit c7fcc69
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63ea643b5752030008b22cb4
😎 Deploy Preview https://deploy-preview-773--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dominikus1993 dominikus1993 changed the title add localstack module (WIP) add localstack module Feb 10, 2023
Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution! I have just one comment regarding WithServices(params AwsService[]) and a question about the tests (I am not done with the review of the tests yet). Anything else is just cosmetic.

I will talk to the other maintainers next week to align the LocalStack module with the other Testcontainers language implementations. I know there is a WIP in Go too.

src/Testcontainers.LocalStack/AwsService.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/AwsService.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/AwsService.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackBuilder.cs Outdated Show resolved Hide resolved
src/Testcontainers.LocalStack/LocalStackContainer.cs Outdated Show resolved Hide resolved
@dgenezini
Copy link

The new health endpoint for localstack container is /_localstack/health.

Using the /health endpoint of localstack gives the following warning in the console:

WARN --- [   asgi_gw_0] localstack.deprecations    : /health is deprecated (since 1.3.0) and will be removed in upcoming releases of LocalStack! Use /_localstack/health instead.

@dominikus1993
Copy link
Contributor Author

dominikus1993 commented Feb 12, 2023

thanks, I didn't noticed I
fixed

Copy link
Collaborator

@HofmeisterAn HofmeisterAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do not need a specific type to set services and we are ok with the health check wait strategy, I am fine with the PR. WDYT @eddumelendez @mdelapenya?

@HofmeisterAn HofmeisterAn changed the title add localstack module feat: Add LocalStack module Feb 13, 2023
@HofmeisterAn HofmeisterAn merged commit b0b52b6 into testcontainers:develop Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants