-
-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LocalStack module #773
feat: Add LocalStack module #773
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
# Conflicts: # Testcontainers.sln
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for your contribution! I have just one comment regarding WithServices(params AwsService[])
and a question about the tests (I am not done with the review of the tests yet). Anything else is just cosmetic.
I will talk to the other maintainers next week to align the LocalStack module with the other Testcontainers language implementations. I know there is a WIP in Go too.
tests/Testcontainers.LocalStack.Tests/LocalStackContainerTests.cs
Outdated
Show resolved
Hide resolved
The new health endpoint for localstack container is Using the
|
thanks, I didn't noticed I |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do not need a specific type to set services and we are ok with the health check wait strategy, I am fine with the PR. WDYT @eddumelendez @mdelapenya?
What does this PR do?
Add support for amazon LocalStack testcontainer module.
Why is it important?
I think that adding this testcontainer will be useful for developers who want to test the operation of multiple aws modules
Related issues
Any of issues are no releated
How to test this PR
Running the new integration test will suffice.