-
-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add GitHub Codespaces configuration (Dev Container) #735
Conversation
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can probably start like this, but I would suggest exploring Devcontainers Features to make the config a bit simpler (e.g. regarding Docker):
https://code.visualstudio.com/blogs/2022/09/15/dev-container-features
Can be done as a follow-up, to just start from a working state, so in favor of merging like this 👍
Looks like dotnet can be also added as a feature |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback. I replaced the Dockerfile with the Dev Container features.
What does this PR do?
This PR contains three major changes. It updates the NuGet dependencies (1) and removes the global output directory (2). Unfortunately, the latest versions of the .NET SDK break more and more things in regards of the global output directory. Considering the GitHub issues it does not look like MS will add the compatibility again (it has worked since the .NET Framework).
Furthermore, it adds a Dev Container configuration to use Testcontainers with GitHub Codespaces (3)
Why is it important?
Simplifies the .NET build and adds GitHub Codespaces support.
Related issues