Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace host port 0 with an empty string #727

Merged
merged 2 commits into from
Jan 4, 2023

Conversation

HofmeisterAn
Copy link
Collaborator

What does this PR do?

Changes the default host port from 0 to an empty string. Considering docker/for-mac#5588 (comment) the implementation of Docker Desktop behaves different. We see this in the chosen ports too. The port ranges are different. This is just the preparation. If there are no issues we can remove ResourceReaperPublicHostPort and the host port 0 configurations from the modules.

Why is it important?

To align with the Java implementation. All TC developers should experience the same behavior.

Related issues

@HofmeisterAn HofmeisterAn added the chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups label Jan 4, 2023
@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for testcontainers-dotnet ready!

Name Link
🔨 Latest commit 3803d69
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-dotnet/deploys/63b559c389c26a0008d0774b
😎 Deploy Preview https://deploy-preview-727--testcontainers-dotnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@HofmeisterAn HofmeisterAn merged commit 514c071 into develop Jan 4, 2023
@HofmeisterAn HofmeisterAn deleted the feature/algin-with-tc-java-port-configuration branch January 4, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A change that doesn't impact the existing functionality, e.g. internal refactorings or cleanups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants