feat(#715): Add HttpWaitStrategy #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-dotnet ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
HofmeisterAn
commented
Dec 20, 2022
kiview
previously approved these changes
Dec 21, 2022
Co-authored-by: Kevin Wittek <[email protected]>
Co-authored-by: Kevin Wittek <[email protected]>
HofmeisterAn
changed the title
HofmeisterAn
changed the title
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the
HttpWaitStrategyimplementation to wait for an HTTP(S) endpoint to return a particular status code.Why is it important?
Other Testcontainers implementations support an HTTP wait strategy. This PR increases the alignment with other languages incl. the development experience.
Related issues
Follow-ups